Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds zone method to rules api. #122

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Adds zone method to rules api. #122

merged 3 commits into from
Jun 25, 2024

Conversation

francocipollone
Copy link
Contributor

@francocipollone francocipollone commented Jun 18, 2024 •
edited
Loading

🎉 New feature

closes #111
closes #114

❗ Goes on top of #121

Summary

  • Adds zone() binding and completes the api

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@francocipollone
Adds LaneSRoute bindings.
da880b2 
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone
Adds zone method to rules api.
23f4afb 
Signed-off-by: Franco Cipollone <[email protected]>
This was referenced Jun 18, 2024
Closed
Closed
agalbachicar
agalbachicar previously approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from francocipollone/lane_s_route to main June 25, 2024 13:16
@francocipollone francocipollone dismissed agalbachicar’s stale review June 25, 2024 13:16

The base branch was changed.

@francocipollone francocipollone merged commit 4463b6d into main Jun 25, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/zone_method_rule branch June 25, 2024 13:24
This was referenced Jun 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust API for RangeValueRule Rust API for DiscreteValueRule
2 participants
@francocipollone @agalbachicar